Increase test coverage for core utilities and misspell modules - #1256
Merged
Conversation
…ll modules Co-authored-by: bact <128572+bact@users.noreply.github.com>
Co-authored-by: bact <128572+bact@users.noreply.github.com>
Co-authored-by: bact <128572+bact@users.noreply.github.com>
…ments Co-authored-by: bact <128572+bact@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Suggest additional code paths for test coverage improvement
Increase test coverage for core utilities and misspell modules
Feb 2, 2026
|
bact
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do
Adds 39+ test cases covering previously untested modules and edge cases, increasing overall test coverage by targeting gaps identified in Coveralls analysis.
Core tests (no dependencies):
pythainlp.tools.core: warn_deprecation(), safe_print() with Unicode/UnicodeEncodeError pathspythainlp.util.encoding: tis620_to_utf8(), to_idna() edge cases (empty strings, Thai domains)pythainlp.ancient: aksonhan_to_current(), convert_currency() boundaries (zero/fractional values, invalid units)Compact tests (numpy dependency):
pythainlp.tools.misspell: search_location_of_character(), find_misspell_candidates() helper functionsWhat was wrong
Multiple modules had zero or minimal test coverage:
tools.corecompletely untestedtools.misspellhelpers only indirectly tested via main functionHow this fixes it
Adds focused test methods targeting specific untested code paths:
All tests follow project categorization (core/compact) and pass successfully.
Your checklist for this pull request
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
coveralls.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.